Woof-CE 3builddistro error/bug/strange definition?

Building a Puppy Linux OS

Moderator: Forum moderators

Post Reply
User avatar
taersh
Posts: 951
Joined: Tue Jul 07, 2020 11:13 pm
Location: Germany
Has thanked: 53 times
Been thanked: 119 times

Woof-CE 3builddistro error/bug/strange definition?

Post by taersh »

Hi.

In Woof-CE script 3builddistro at line 258:

EXTRAS_LIST="${ADRV_INC// /|} ${YDRV_INC// /|} ${AFDRV_INC// /|}"

What is that (the red one) ?
I don't think it would be possible to add an afdrv .sfs to Puppy, no?

It seems not to be used in all the Woof-CE scripts.

My Music:
https://soundcloud.com/user-633698367
Using my own build of Bionic64
The far-left is as fascist as the far-right is!

User avatar
wiak
Posts: 3665
Joined: Tue Dec 03, 2019 6:10 am
Location: Packing - big job
Has thanked: 56 times
Been thanked: 1027 times
Contact:

Re: Woof-CE 3builddistro error/bug/strange definition?

Post by wiak »

taersh wrote: Sat Mar 20, 2021 3:11 am

Hi.

In Woof-CE script 3builddistro at line 258:

EXTRAS_LIST="${ADRV_INC// /|} ${YDRV_INC// /|} ${AFDRV_INC// /|}"

What is that (the red one) ?
I don't think it would be possible to add an afdrv .sfs to Puppy, no?

It seems not to be used in all the Woof-CE scripts.

If not intended somehow, then maybe a typo/error and should be ${FDRV_INC// /|}?"

https://www.tinylinux.info/
DOWNLOAD wd_multi for hundreds of 'distros' at your fingertips: viewtopic.php?p=99154#p99154
Αξίζει να μεταφραστεί;

dimkr
Posts: 1982
Joined: Wed Dec 30, 2020 6:14 pm
Has thanked: 37 times
Been thanked: 896 times

Re: Woof-CE 3builddistro error/bug/strange definition?

Post by dimkr »

adrv support works, look at fossa64.

This testing build has a functional adrv - https://github.com/dimkr/woof-CE/releas ... 9.499-adrv

dimkr
Posts: 1982
Joined: Wed Dec 30, 2020 6:14 pm
Has thanked: 37 times
Been thanked: 896 times

Re: Woof-CE 3builddistro error/bug/strange definition?

Post by dimkr »

This ugly and unreadable loop takes a list of packages like "abiword gnumeric" and converts it into "abiword|gnumeric", then passes that through grep, so it filters lines containing one of the package names.

This area had a bug I fixed recently, in https://github.com/puppylinux-woof-CE/w ... 2135/files. 3builddistro didn't filter out comments, so lines containing the word "abiword" in a comment got ignored, and gmp (a dependency of GCC) didn't get added to rootfs-complete, breaking fossa64.

Make sure on you're on the latest woof-CE (git pull), it's fixed now.

EDIT: ha, this typo can break fdrv, not adrv.

Post Reply

Return to “woof-CE”